[coreboot-gerrit] Change in coreboot[master]: mb/ocp/deltalake: Populate SMBIOS data and set the read PPIN to BMC

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41279 )

Change subject: mb/ocp/deltalake: Populate SMBIOS data and set the read PPIN to BMC
......................................................................

Patch Set 10:

(3 comments)

https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak... 
File src/mainboard/ocp/deltalake/ipmi.h:

https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak... 
PS10, Line 2: /* This file is part of the coreboot project. */
please remove

https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak... 
PS10, Line 6: #include <types.h>
This is OK.

but you are including : <commonlib/bsd/cb_err.h>, <stdbool.h> and <stddef.h> 
for just 'unit32_t and uint8_t
(I would include only <stdint.h>)

https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak... 
PS10, Line 6: #include <types.h>
please insert a line between "#define DELTALAKE_IPMI_H" and "#include..."