Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37554 )
Change subject: soc/intel/Kconfig: Load tigerlake SOC Kconfig
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 2: Code-Review-1
Order might matter here, that `common/Kconfig` is sourced last
is likely intentional.
Usually this is done so that the common code can provide a default
and SoCs can override it (first `default` line encountered by
Kconfig takes precedence).
That is a valid point.
What do you think about:
Rename: src/soc/intel/common/Kconfig to src/soc/intel/common/Kconfig.common
Change: All specific SoC sources to "source src/soc/intel/*/Kconfig"
Change: Common source to "source src/soc/intel/common/Kconfig.common"
It just gets rid of the work to add every single Intel SoC to be sourced separately.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37554
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25463f1b7b5d8242da3decf3e7a7ca54c699d467
Gerrit-Change-Number: 37554
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 06:42:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment