Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31147 )
Change subject: soc/intel/apollolake: Fix XHCI device name in ACPI
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31147/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31147/1//COMMIT_MSG@9
PS1, Line 9: XHC1
Looks to me this string error is coming from src/soc/intel/apollolake/chip.c: […]
Correct. That path returns XHCI and not XHC1 and hence the error. Looking at soc/intel/, all SoCs except apollolake and denverton_ns seem to be using XHC1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4921547fee6fb51333319b9e881501a7e75ebce
Gerrit-Change-Number: 31147
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Jan 2019 23:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment