[coreboot-gerrit] New patch to review for coreboot: 222d9b9 Supermicro H8QGI: Change default interrupt model to PIC, according ACPI specification

[Aladyshev Konstantin]

Aladyshev Konstantin ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5473

-gerrit

commit 222d9b917a5b31cfaacb9b26db59baca563a49b4
Author: Konstantin Aladyshev 
Date:   Sat Jul 12 02:36:32 2014 +0400

Supermicro H8QGI: Change default interrupt model to PIC, according ACPI specification

According ACPI specification:

"""
    The _PIC optional method is used to report to the BIOS the current
    interrupt model used by the OS. The argument passed into the method
    signifies the interrupt model OSPM has chosen, PIC mode, APIC mode,
    or SAPIC mode. Notice that calling this method is optional for OSPM.
    If the method is never called, the BIOS must assume PIC mode.

Arguments: (1)
    Arg0 – An Integer containing a code for the current interrupt model:
    0 –PIC mode
    1 –APIC mode
    2 –SAPIC mode
    """

In current configuration with default value of interrupt model
    PMOD equal 1 (APIC mode), Linux can't boot with "noapic" option.
    Kernel never call _PIC method and PMOD stays equal 1, indicatind
    that APIC routing objects should be evaluated. This mix of PIC
    and APIC leads to boot fail.

Change default value of interrupt model PMOD to 1, for correct
    "noapic" boot.

Change-Id: I7fa6f0c24802751202ed2e7f13411001a600e772
    Signed-off-by: Konstantin Aladyshev 
---
 src/mainboard/supermicro/h8qgi/dsdt.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/supermicro/h8qgi/dsdt.asl b/src/mainboard/supermicro/h8qgi/dsdt.asl
index c854067..b829584 100644
--- a/src/mainboard/supermicro/h8qgi/dsdt.asl
+++ b/src/mainboard/supermicro/h8qgi/dsdt.asl
@@ -57,7 +57,7 @@ DefinitionBlock (
    /* Some global data */
    Name(OSTP, 3)		/* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */
    Name(OSV, Ones)	/* Assume nothing */
-	Name(PMOD, One)	/* Assume APIC */
+	Name(PMOD, 0)	/* Default interrupt model is PIC */

/*
     * Processor Object