Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37306 )
Change subject: trogdor: mainboard reference all QUPv3 FW drivers ......................................................................
Patch Set 25:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37306/20/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37306/20/src/mainboard/google/trogd... PS20, Line 42: qup_load_se_firmware(QUPV3_1_SE4, SE_PROTOCOL_SPI); /* Fingerprint SPI */
nit: Would be nice to order these by QUP number.
Done
https://review.coreboot.org/c/coreboot/+/37306/21/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37306/21/src/mainboard/google/trogd... PS21, Line 69: i2c_init(QUPV3_1_SE3, I2C_SPEED_FAST); /* Speaker Amps I2C */
Why isn't this just a qupv3_se_fw_load_and_init() like the rest? Looks like we can play the beep wit […]
Done