Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40694 )
Change subject: soc/intel/apl: Add panel power and backlight configuration ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40694/1/src/drivers/intel/gma/i915_... File src/drivers/intel/gma/i915_reg.h:
https://review.coreboot.org/c/coreboot/+/40694/1/src/drivers/intel/gma/i915_... PS1, Line 1717: /* BXT backlight register definition. */ No dot/period at the end needed.
https://review.coreboot.org/c/coreboot/+/40694/1/src/soc/intel/apollolake/gr... File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/40694/1/src/soc/intel/apollolake/gr... PS1, Line 40: i Reading the signature, I do not know, whatr *i* is supposed to be. Can we find something better?