Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38821 )
Change subject: cpu/x86/smm: Remove blank line in code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38821/2/src/cpu/x86/smm/smm_module_...
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/38821/2/src/cpu/x86/smm/smm_module_...
PS2, Line 399: // account for the bios resource list
Done
My original thought was to remove both blank lines and possibly the
intermediate comment, becasue the comment in line 396 refers to line
403. Doesn't matter much, the new code will likely be removed here
midterm. No need to bikeshed cosmetics in this case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9754c6723ecd5e4895898490fc7228e1c3839d0
Gerrit-Change-Number: 38821
Gerrit-PatchSet: 2
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Feb 2020 09:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: cedarhouse1@comcast.net
Gerrit-MessageType: comment