Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51853 )
Change subject: mb/google/kukui: fix the issue of getting error panel_id ......................................................................
mb/google/kukui: fix the issue of getting error panel_id
Current get panel_id is over sku_id() >> 4, but sku_id is combined with wfc_id/lcm_id/sku_id, so the panel_id value is wfc_id << 4 | lcm_id() in fact. When wfc_id is not 0, the panel_id will be wrong. So only get the low 4 bits for the panel_id.
BUG=b:183779755 BRANCH=kukui TEST=emerge-kukui
Change-Id: I63e0c8a2719462a9b979afe52a27c78b9fc804e8 Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/51853 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index fbdf633..893d94d 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -124,7 +124,7 @@ static struct panel_description *get_active_panel(void) { /* TODO(hungte) Create a dedicated panel_id() in board_id.c */ - int panel_id = sku_id() >> 4; + int panel_id = sku_id() >> 4 & 0x0F;
struct panel_description *panel = get_panel_description(panel_id); if (!panel) {