Attention is currently required from: Andrey Petrov, Appukuttan V K, Ronak Kanabar, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81661?usp=email )
Change subject: drivers/intel/fsp2_0:Make coreboot FSP stack 16-bytes aligned
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81661/comment/c4fca8ba_23e3110f :
PS2, Line 7: drivers/intel/fsp2_0:Make
Please add a space after the alignment.
https://review.coreboot.org/c/coreboot/+/81661/comment/db2f484d_4b3f6958 :
PS2, Line 9: - Stack alignment:
Making this an item seems unnecessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81661?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c
Gerrit-Change-Number: 81661
Gerrit-PatchSet: 2
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 04 Apr 2024 10:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment