Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31108 )
Change subject: sb/intel/common/firmware: Don't call GbE binary `firmware`
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31108/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31108/1//COMMIT_MSG@8
PS1, Line 8:
The GbE binary holds the MAC address the integrated Ethernet uses. […]
can you please point me to the document where you get those details about referring as Gbe "configuration"
This is what I could see at Intel document, not sure if you have a better version ?
SPI programming guide tells me the purpose of this Gbe region that you have modified in this CL:
GbE – Location for Integrated LAN firmware and MAC address
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife6190639e7f05da2cb6eddeb1b0db0e8ffc8e6e
Gerrit-Change-Number: 31108
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Jan 2019 14:16:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment