Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40421 )
Change subject: soc/amd/picasso: Allow mainboard to configure SPI settings ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40421/8/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/40421/8/src/soc/amd/picasso/chip.h@... PS8, Line 84: spi_read_mode
Instead of placing all these in the main picasso config, would it be cleaner if we defined a SPI chi […]
Interesting idea. I went with this because this is what we have been doing for all platforms (Intel as well). And for other IPs too: Example I2C config on lines 25-26.
Also, we don't really have a SPI device in the devicetree. In my opinion, let's continue with this for now and we can look at all the IPs together and see if adding chip drivers for each separately makes sense.