Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31505 )
Change subject: src/soc/intel/cannonlake: Add PsysPmax setting ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31505/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31505/1//COMMIT_MSG@17 PS1, Line 17: exmaple example
https://review.coreboot.org/#/c/31505/1/src/soc/intel/cannonlake/fsp_params.... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/31505/1/src/soc/intel/cannonlake/fsp_params.... PS1, Line 95: psys_pmax Should this be PsysPmax? since psys_pmax is in W and PsysPmax is in units of 1/8 W.