Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30971 )
Change subject: util/autoport: Make dsdt.asl prettier ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/30971/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30971/2//COMMIT_MSG@9 PS2, Line 9: OCD-inducing
Maybe drop this part.
I didn't know of a better way to describe them...
https://review.coreboot.org/#/c/30971/2/util/autoport/main.go File util/autoport/main.go:
https://review.coreboot.org/#/c/30971/2/util/autoport/main.go@848 PS2, Line 848: #include <arch/acpi.h>
I think there should be a blank line between this and the DefinitionBlock.
Okay, sounds good.
https://review.coreboot.org/#/c/30971/2/util/autoport/main.go@858 PS2, Line 858: /* Some generic macros */
Is this comment really needed?
Not really, it is rather obnoxious.