Change in ...coreboot[master]: util/autoport: Make dsdt.asl prettier

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

16 Jan 2019 16 Jan '19

10:07 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30971

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

util/autoport: Make dsdt.asl prettier

Small cosmetic changes which fix OCD-inducing aesthetic inaccuracies.

Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/main.go 1 file changed, 7 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/30971/1

diff --git a/util/autoport/main.go b/util/autoport/main.go index ee26966..5d660d1 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -842,13 +842,14 @@

for _, define := range DSDTDefines { if define.Comment != "" { - fmt.Fprintf(dsdt, "\t/* %s. */\n", define.Comment) + fmt.Fprintf(dsdt, "\t/* %s. */\n", define.Comment) } dsdt.WriteString("#define " + define.Key + " " + define.Value + "\n") }

dsdt.WriteString( - `#include <arch/acpi.h> + ` +#include <arch/acpi.h> DefinitionBlock( "dsdt.aml", "DSDT", @@ -858,7 +859,7 @@ 0x20141018 // OEM revision ) { - // Some generic macros + /* Some generic macros */ #include "acpi/platform.asl" `)

@@ -870,9 +871,8 @@ }

dsdt.WriteString(` - Scope (_SB) { - Device (PCI0) - { + Device (_SB.PCI0) + { `) for _, x := range DSDTPCI0Includes { if x.Comment != "" { @@ -881,8 +881,7 @@ fmt.Fprintf(dsdt, "\t\t#include <%s>\n", x.File) } dsdt.WriteString( - ` } - } + ` } } `)

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Angel Pons (Code Review)

17 Jan 17 Jan

12:15 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30971

to look at the new patch set (#2).

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

util/autoport: Make dsdt.asl prettier

Small cosmetic changes which fix OCD-inducing aesthetic inaccuracies.

Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/main.go 1 file changed, 9 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/30971/2

Tristan Corrick (Code Review)

5:26 a.m.

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30971 )

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/30971/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30971/2//COMMIT_MSG@9 PS2, Line 9: OCD-inducing Maybe drop this part.

https://review.coreboot.org/#/c/30971/2/util/autoport/main.go File util/autoport/main.go:

https://review.coreboot.org/#/c/30971/2/util/autoport/main.go@848 PS2, Line 848: #include <arch/acpi.h> I think there should be a blank line between this and the DefinitionBlock.

https://review.coreboot.org/#/c/30971/2/util/autoport/main.go@858 PS2, Line 858: /* Some generic macros */ Is this comment really needed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/30971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Gerrit-Change-Number: 30971 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 17 Jan 2019 04:26:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

11:44 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30971 )

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/30971/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30971/2//COMMIT_MSG@9 PS2, Line 9: OCD-inducing

...

Maybe drop this part.

I didn't know of a better way to describe them...

https://review.coreboot.org/#/c/30971/2/util/autoport/main.go File util/autoport/main.go:

https://review.coreboot.org/#/c/30971/2/util/autoport/main.go@848 PS2, Line 848: #include <arch/acpi.h>

...

I think there should be a blank line between this and the DefinitionBlock.

Okay, sounds good.

https://review.coreboot.org/#/c/30971/2/util/autoport/main.go@858 PS2, Line 858: /* Some generic macros */

...

Is this comment really needed?

Not really, it is rather obnoxious.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Gerrit-Change-Number: 30971 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 17 Jan 2019 10:44:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tristan Corrick tristan@corrick.kiwi Gerrit-MessageType: comment

Tristan Corrick (Code Review)

1:15 p.m.

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30971 )

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30971/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30971/2//COMMIT_MSG@9 PS2, Line 9: OCD-inducing

...

I didn't know of a better way to describe them...

I think the description is still apt without the OCD part.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Gerrit-Change-Number: 30971 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 17 Jan 2019 12:15:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Tristan Corrick tristan@corrick.kiwi Gerrit-MessageType: comment

Angel Pons (Code Review)

9:20 p.m.

Hello Tristan Corrick, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30971

to look at the new patch set (#3).

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

util/autoport: Make dsdt.asl prettier

Small cosmetic changes which fix aesthetic inaccuracies.

Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/main.go 1 file changed, 9 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/30971/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/30971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Gerrit-Change-Number: 30971 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tristan Corrick (Code Review)

18 Jan 18 Jan

2:01 a.m.

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30971 )

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Gerrit-Change-Number: 30971 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 18 Jan 2019 01:01:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 Jan 20 Jan

9:53 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30971 )

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

util/autoport: Make dsdt.asl prettier

Small cosmetic changes which fix aesthetic inaccuracies.

Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/30971 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tristan Corrick tristan@corrick.kiwi --- M util/autoport/main.go 1 file changed, 9 insertions(+), 10 deletions(-)

Approvals: build bot (Jenkins): Verified Tristan Corrick: Looks good to me, approved

diff --git a/util/autoport/main.go b/util/autoport/main.go index 05a829b..dc02a8d 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -838,13 +838,14 @@

dsdt.WriteString( - `#include <arch/acpi.h> + ` +#include <arch/acpi.h> DefinitionBlock( "dsdt.aml", "DSDT", @@ -854,31 +855,29 @@ 0x20141018 // OEM revision ) { - // Some generic macros + /* Some generic macros */ #include "acpi/platform.asl" `)

for _, x := range DSDTIncludes { if x.Comment != "" { - fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment) + fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment) } fmt.Fprintf(dsdt, "\t#include <%s>\n", x.File) }

dsdt.WriteString(` - Scope (_SB) { - Device (PCI0) - { + Device (_SB.PCI0) + { `) for _, x := range DSDTPCI0Includes { if x.Comment != "" { - fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment) + fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment) } fmt.Fprintf(dsdt, "\t\t#include <%s>\n", x.File) } dsdt.WriteString( - ` } - } + ` } } `)

-- To view, visit https://review.coreboot.org/c/coreboot/+/30971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Gerrit-Change-Number: 30971 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

Arthur Heymans (Code Review)

3 Nov 3 Nov

7:55 a.m.

New subject: Change in coreboot[master]: util/autoport: Make dsdt.asl prettier

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30971 )

Change subject: util/autoport: Make dsdt.asl prettier ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/30971/4/util/autoport/main.go File util/autoport/main.go:

https://review.coreboot.org/c/coreboot/+/30971/4/util/autoport/main.go@870 PS4, Line 870: Device (_SB.PCI0) : { This change is not cosmetic.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe Gerrit-Change-Number: 30971 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 03 Nov 2019 06:55:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1635

days inactive

1926

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Patrick Georgi (Code Review)
Tristan Corrick (Code Review)