Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39669 )
Change subject: mb/intel/jasperlake_rvp: Add camera support Jasper Lake RVP ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39669/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39669/15//COMMIT_MSG@9 PS15, Line 9: 1. Add support as per the schematics : 2. Add 2 Ports and 2 Endpoints nit: Add some more information here, like below World facing sensor on I2C5 using 2 data lanes with VCM support User facing sensor on I2C4 using 2 data lanes
https://review.coreboot.org/c/coreboot/+/39669/15//COMMIT_MSG@11 PS15, Line 11: OTVI5676 OVTI5675?
https://review.coreboot.org/c/coreboot/+/39669/15/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/39669/15/src/mainboard/intel/jasper... PS15, Line 49: Device (CAM0) The same sensor in CAM1 has a VCM device? shouldn't this one also contain an entry for VCM?