Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43760 )
Change subject: mb/clevo/kbl-u: Add Clevo N240BU as variant
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/...
File src/mainboard/clevo/kbl-u/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/...
PS14, Line 191: register "serirq_mode" = "SERIRQ_CONTINUOUS"
you can drop that; serirq is only used for ec, which can make use of quiet mode and thus save power
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57dc2db78c66dd93642f41d10343d1be05fb9f17
Gerrit-Change-Number: 43760
Gerrit-PatchSet: 14
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 27 Jul 2020 17:04:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment