Attention is currently required from: Arthur Heymans, Felix Held, Martin L Roth, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76506?usp=email )
Change subject: soc/amd/genoa: Add aoac.c & enable AOAC devices early
......................................................................
Patch Set 10:
(1 comment)
File src/soc/amd/genoa/aoac.c:
https://review.coreboot.org/c/coreboot/+/76506/comment/b7b03659_a459d678 :
PS9, Line 22: 100
Do we know why this value was chosen, or what the typical amount of time is? Can this be smaller?
looks like this is inline with all the other AMD SoC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76506?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9553e6016c92c9b1678c395cd6a9e6860bf8a76
Gerrit-Change-Number: 76506
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 06 Oct 2023 14:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment