Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48322 )
Change subject: Revert "util: Remove 'getpir' and 'mptable' tools"
......................................................................
Patch Set 2:
Verify that files don't have the old style header (lint-stable-009-old-licenses): util/getpir/code_gen.c has the old GPL header.
test failed
Also, maybe should write a better footnote than "Done, you can move the file to the coreboot tree now." Current version's output is incorrect and has to be parsed by human to get something useful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48322
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieff7673387ae9275b8271f4a483926b774697a8d
Gerrit-Change-Number: 48322
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 06 Dec 2020 20:20:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment