Attention is currently required from: Tim Wawrzynczak, Arthur Heymans, Aaron Durbin. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54302 )
Change subject: Kconfig: Fix BOOT_DEVICE_MEMORY_MAPPED ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54302/comment/307f579a_1612d484 PS1, Line 7: Fix BOOT_DEVICE_MEMORY_MAPPED : : Also non SPI x86 is memory mapped.
On some older boards there is LPC flash instead of SPI. Emulation qemu boards also don't have SPI emulated.
In these cases, is the boot medium still memory mapped? If so, it looks like you need the selection of `BOOT_DEVICE_MEMORY_MAPPED` config for the mainboards rather than changing the default selection of the config. Or are there more things to consider?
To answer Furquans question: It looks like it is only used in arch/x86/postcar_loader.c to set up a WP MTRR for the ROM.
Sorry, I still did not understand the intention. For the case that you are considering: 1. What is the boot medium? 2. Is it still SPI flash? 3. If not: a. Is the non-SPI flash boot medium memory mapped? b. In this case, is the SPI flash still memory mapped? Do you intend to configure things for the memory mapped SPI flash in postcar even though it is not the boot medium?