Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41737 )
Change subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0 ......................................................................
resource_allocator_v4: Fix size of I/O hole at 0x3b0
Addressing comment from CB:41443 that was received after the change landed. memranges_create_hole() takes size as the last parameter. So, the I/O hole created at 0x3b0 needs to set size as 0x3df - 0x3b0 + 1 as 0x3df is the upper limit of that hole.
Change-Id: I08fca283436924427e12c6c69edced7e51db42a9 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41737 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/device/resource_allocator_v4.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Aaron Durbin: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c index ece7150..b65fc8b 100644 --- a/src/device/resource_allocator_v4.c +++ b/src/device/resource_allocator_v4.c @@ -330,7 +330,7 @@ * Don't allow allocations in the VGA I/O range. PCI has special cases for * that. */ - memranges_create_hole(ranges, 0x3b0, 0x3df); + memranges_create_hole(ranges, 0x3b0, 0x3df - 0x3b0 + 1);
/* * Resource allocator no longer supports the legacy behavior where I/O resource