Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 54: S nit: Add another space to align with the SA_DEVFN below?
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 57: PCI_DEVFN(SA_DEV_SLOT_TCSS, 2) Use SA_DEVFN_TCSS_DMA(0)?
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 58: PCI_DEVFN(SA_DEV_SLOT_TCSS, 3) Use SA_DEVFN_TCSS_DMA(1)?