Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63863 )
Change subject: soc/intel/elkhartlake: Provide ability to update TSN GbE MAC addresses ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63863/comment/8d313aaf_13fc97d9 PS2, Line 11: adr_to_set
Maybe just call it 'mac' here to shorten down the name a bit?
Done
https://review.coreboot.org/c/coreboot/+/63863/comment/340017b7_9790aebd PS2, Line 16: printk(BIOS_ERR, "TSN GbE: No valid MAC address found\n");
I wouldn't print that with ERROR level as there are valid cases where the mainboard code does not pr […]
Done
https://review.coreboot.org/c/coreboot/+/63863/comment/49514650_23710615 PS2, Line 25: *mac_p = (*mac_p & 0xFFFF0000) | (adr_to_set[5] << 8) | adr_to_set[4];
How about uing clrsetbits32() from device/mmio.h here? Could look like: […]
Great idea. Thanks!