Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31260 )
Change subject: coreboot: check TPM mode on normal boot ......................................................................
Patch Set 1:
(2 comments)
as a general comment: adding any tpm communication to the main boot flow adds something like 8 ms to the boot time, it should be avoided unless absolutely necessary.
https://review.coreboot.org/#/c/31260/1/src/vendorcode/google/chromeos/cr50_... File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/#/c/31260/1/src/vendorcode/google/chromeos/cr50_... PS1, Line 84: if (vboot_recovery_mode_enabled())
Vadim - what's the rationale for skipping the Cr50 update check when recovery mode is enabled? Is t […]
I think recovery request could be lost if we reboot, we don't want this to happen.
https://review.coreboot.org/#/c/31260/1/src/vendorcode/google/chromeos/cr50_... PS1, Line 96: tlcl_cr50_enable_update isn't this command goiong to timeout if tpm is disabled?