Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Please use lenovo/t530 as reference.
What _exactly_ do you mean?
If you mean the baseboard scheme: that would not be correct as there is no such. x11ssh and x11ssm and others are very similiar but are different boards. I used the Gigabyte boards' scheme.
Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Then suggest a better naming, please. Naming it "x11ss" wouldn't fit, same problem. Naming it "x11ssh" would be wrong, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29
Gerrit-Change-Number: 35426
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 16 Sep 2019 09:54:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment