[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/block/psp: Add platform secure boot support

[ritul guru (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Angel Pons, Aamir Bohra, Felix Held.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60968 )

Change subject: soc/amd/common/block/psp: Add platform secure boot support
......................................................................

Patch Set 7:

(4 comments)

File src/soc/amd/common/block/psp/psb.c:

https://review.coreboot.org/c/coreboot/+/60968/comment/c7cdb874_0f2e0b09 
PS5, Line 224: 		cold_reset();
> i like the idea of putting the cold reset into psb_enable since it would avoid the need for an succe […]

Ack

File src/soc/amd/common/block/psp/psb.c:

https://review.coreboot.org/c/coreboot/+/60968/comment/21cb831d_bb83e871 
PS6, Line 152: int
> the return value is success/error/reboot, so enum cb_err in the current form isn't sufficient. […]

moved cold_reset inside psb_enable(), in that case introducing CB_NEED_REBOOT is not required.

https://review.coreboot.org/c/coreboot/+/60968/comment/4e386885_35004da7 
PS6, Line 173: CB_ERR
> this isn't an error

Ack

https://review.coreboot.org/c/coreboot/+/60968/comment/839bd3d7_a2ee53e4 
PS6, Line 219: int ret;
> this variable isn't needed; i'd just check the return value of the function in the if statement

Ack