Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46895 )
Change subject: soc/intel/xeon_sp/cpx: Align coreboot CAR symbols to FSP-T ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46895/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46895/1//COMMIT_MSG@14 PS1, Line 14: TEST: boot with ocp/deltalake.
But it was booting before? Maybe mention that stack no longer gets smashed?
TEST=Boot ocp/deltalake, stack no longer gets smashed in romstage.
Yes, so during FSP-M it smashes coreboot things but that's not a problem for FSP-M. The stack is really overflowing it's size. The romstage message about smashed stack does indeed go away.