Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38984 )
Change subject: mb/google/{auron,slippy}/ec: clear pending events on S3 wakeup ......................................................................
Patch Set 3:
Patch Set 3:
Side-effect of this change would be that if you close lid in depthcharge or later phases of coreboot, it wouldn't result in shut down. In developer and normal mode, it would just boot to OS and shut down there. In case of recovery, I believe it would just be stuck at the recovery screen.
I see some common code that checks to see if the lid is closed. Is that not being used for this platform? https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/pl...
I suspect not with Matt's images since he isn't using vboot+depthcharge.
On x86 devices we were relying on the SMI handler for lid and power button events (and manipulating the EC event masks to enable/disable as needed) but it is used on ARM and Wilco devices.