[coreboot-gerrit] Change in coreboot[master]: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38780 )

Change subject: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... 
File src/security/vboot/bootmode.c:

https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... 
PS2, Line 65: 	if (get_recovery_mode_switch())
> If we are going to rely on the assertion in vboot_get_context(), we may as well do the same for reco […]

Yes, all those cases you listed are running after verstage (at least for STARTS_IN_BOOTBLOCK which should be all affected platforms). I think it might be helpful to trigger that assertion to make people aware if they're calling an API that has no defined result at that point.