Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 )
Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
......................................................................
Patch Set 10:
(2 comments)
File src/drivers/wwan/fm/Kconfig:
https://review.coreboot.org/c/coreboot/+/61354/comment/6c06812e_06103a4a
PS10, Line 9:
Sorry I meant can you add something about that in the help text?
will do.
File src/drivers/wwan/fm/chip.h:
https://review.coreboot.org/c/coreboot/+/61354/comment/b5f9b561_487ab1a3
PS10, Line 21: RTD3
Sorry meant to erase that comment once I figured it out
No problem. I think I was not clear about adding such reference. Supposed we have two devices; one on CPU RP; and the other one PCH RP. And they all use rtd3 methods. Each device can reference its corresponding rtd3 instance config specified from the devicetree so that they knows what rtd3 methods are available to them. In CPU case, no modPHY power gate support, while PCH one does.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61354
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566
Gerrit-Change-Number: 61354
Gerrit-PatchSet: 10
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Comment-Date: Fri, 04 Feb 2022 23:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment