[coreboot-gerrit] Change in coreboot[master]: soc/amd: move non-CAR linker scripts to common directory

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47828 )

Change subject: soc/amd: move non-CAR linker scripts to common directory
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
PS2, Line 86: 	_ = ASSERT(CONFIG_BOOTBLOCK_ADDR == ((CONFIG_BOOTBLOCK_ADDR + 0xFFFF) & 0xFFFF0000), "Bootblock must be 16 bit aligned");
Is this correct?

The architectural requirement is for X86_RESET_VECTOR to have the traditional IP 0xfff0. So it is the end of bootblock that must be at 64KiB boundary. AFAICS, C_ENV_BOOTBLOCK_SIZE has no requirements on alignment, so 16 bytes might a sufficient and convenient alignment for BOOTBLOCK_ADDR.