Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver
......................................................................
Patch Set 27:
(1 comment)
still two comments (one to add timeout duration, one to answer yupingso's questions).
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi...
File src/soc/mediatek/mt8192/pmif_spi.c:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi...
PS7, Line 287: if (ret != 0) {
Would you please give me a hint about CB_SUCCESS and friends? […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45398
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32fc28f72d9522133baa06f9d67c383f814d862c
Gerrit-Change-Number: 45398
Gerrit-PatchSet: 27
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 02:08:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-MessageType: comment