Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32705 )
Change subject: security/lockdown: Write-protect WP_RO ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/32705/13/src/include/boot_device.h File src/include/boot_device.h:
https://review.coreboot.org/c/coreboot/+/32705/13/src/include/boot_device.h@... PS13, Line 79: ENV_VERSTAGE
Ok, will change.
Done
https://review.coreboot.org/c/coreboot/+/32705/13/src/security/lockdown/Kcon... File src/security/lockdown/Kconfig:
https://review.coreboot.org/c/coreboot/+/32705/13/src/security/lockdown/Kcon... PS13, Line 65: BOOTMEDIA_LOCK_IN_VERSTAGE
FWIW I think this would be a bit cleaner by moving even more options out of the choice block, becaus […]
Done
https://review.coreboot.org/c/coreboot/+/32705/14/src/security/lockdown/Kcon... File src/security/lockdown/Kconfig:
https://review.coreboot.org/c/coreboot/+/32705/14/src/security/lockdown/Kcon... PS14, Line 60: fmap
capitalize
Done