Hello Aaron Durbin, Patrick Rudolph, Subrata Banik, Julius Werner, Arthur Heymans, Tim Wawrzynczak, V Sowmya, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35639
to look at the new patch set (#3).
Change subject: coreboot_table: Use fmap_locate_area_as_rdev() for fmap_offset ......................................................................
coreboot_table: Use fmap_locate_area_as_rdev() for fmap_offset
CB:35377 changed the behavior of find_fmap_directory() to return pointer to CBMEM_ID_FMAP if fmap is cached in cbmem. lb_boot_media_params() calls find_fmap_directory() to add offset of fmap in flash to coreboot table. However, because of the change in behavior of find_fmap_directory(), it ended up adding 0 as the offset.
This change uses fmap_locate_area_as_rdev() instead of find_fmap_directory() to get to the offset of FMAP in flash. Ideally, all payloads should move to using the FMAP from CBMEM. However, in order to maintain compatibility with payloads which are not updated, ensure that fmap_offset is updated correctly.
Since find_fmap_directory() is no longer used outside fmap.c, this change also removes it from fmap.h and limits scope to fmap.c.
In a follow up patch, we need to push a change to libpayload to expose the fmap cache pointer to lib_sysinfo.
BUG=b:141723751
Change-Id: I7ff6e8199143d1a992a83d7de1e3b44813b733f4 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/include/fmap.h M src/lib/coreboot_table.c M src/lib/fmap.c 3 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/35639/3