Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8016
-gerrit
commit 0ae3c77ec3cbcd6b21f0c63b2fa722f2dd7cbec3 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Thu Jan 1 04:02:55 2015 +1100
amd/agesa/family12/dimmSpd.c: Indent (tab) fix
Trivial; Use tab over space for indent. Clean up some ASCII art while here.
Change-Id: Id2478d140a98596c5eeefdf5b047c1ca23203909 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/northbridge/amd/agesa/family12/dimmSpd.c | 44 +++++++++++++++------------- 1 file changed, 23 insertions(+), 21 deletions(-)
diff --git a/src/northbridge/amd/agesa/family12/dimmSpd.c b/src/northbridge/amd/agesa/family12/dimmSpd.c index e8ef02a..3fbc6df 100644 --- a/src/northbridge/amd/agesa/family12/dimmSpd.c +++ b/src/northbridge/amd/agesa/family12/dimmSpd.c @@ -1,4 +1,4 @@ -/***************************************************************************** +/* * * Copyright (c) 2011, Advanced Micro Devices, Inc. * All rights reserved. @@ -25,7 +25,7 @@ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * - ***************************************************************************/ + */
#include <stdlib.h> #include "Porting.h" @@ -34,20 +34,21 @@
#include <northbridge/amd/agesa/dimmSpd.h>
-typedef struct _DIMM_INFO_SMBUS{ - UINT8 SocketId; - UINT8 MemChannelId; - UINT8 DimmId; - UINT8 SmbusAddress; +typedef struct _DIMM_INFO_SMBUS { + UINT8 SocketId; + UINT8 MemChannelId; + UINT8 DimmId; + UINT8 SmbusAddress; } DIMM_INFO_SMBUS; + /* * SPD address table - porting required */ STATIC CONST DIMM_INFO_SMBUS SpdAddrLookup [] = { - /* Socket, Channel, Dimm, Smbus */ - {0, 0, 0, 0xA0}, - {0, 1, 0, 0xA2} + /* Socket, Channel, Dimm, Smbus */ + {0, 0, 0, 0xA0}, + {0, 1, 0, 0xA2} };
AGESA_STATUS @@ -57,17 +58,18 @@ AmdMemoryReadSPD ( IN OUT AGESA_READ_SPD_PARAMS *SpdData ) { - UINT8 SmBusAddress = 0; - UINTN Index; - UINTN MaxSocket = ARRAY_SIZE(SpdAddrLookup); - for (Index = 0; Index < MaxSocket; Index ++){ - if ((SpdData->SocketId == SpdAddrLookup[Index].SocketId) && - (SpdData->MemChannelId == SpdAddrLookup[Index].MemChannelId) && - (SpdData->DimmId == SpdAddrLookup[Index].DimmId)) { - SmBusAddress = SpdAddrLookup[Index].SmbusAddress; - break; - } - } + UINT8 SmBusAddress = 0; + UINTN Index; + UINTN MaxSocket = ARRAY_SIZE(SpdAddrLookup); + + for (Index = 0; Index < MaxSocket; Index ++) { + if ((SpdData->SocketId == SpdAddrLookup[Index].SocketId) && + (SpdData->MemChannelId == SpdAddrLookup[Index].MemChannelId) && + (SpdData->DimmId == SpdAddrLookup[Index].DimmId)) { + SmBusAddress = SpdAddrLookup[Index].SmbusAddress; + break; + } + }
if (SmBusAddress == 0) return AGESA_ERROR;