Attention is currently required from: Ravi kumar, Paul Menzel, Sudheer Amrabadi, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: soc/qualcomm: Commonize AOP firmware support
......................................................................
Patch Set 81:
(1 comment)
File src/soc/qualcomm/sc7180/mmu.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/35cd0c54_0cf44901
PS80, Line 22:
: void soc_mmu_dram_config_post_dram_init(void)
: {
: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM);
: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM);
: }
:
I think that you just removed this functionality in this patch? You probably need to pull CB:58372 […]
This functionality is still being pulled out from this patchset and will break trogdor.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90b0f48e15df390970e027bff2065b7a89b14cec
Gerrit-Change-Number: 49767
Gerrit-PatchSet: 81
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 20 Oct 2021 16:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment