PraveenX Hodagatta Pranesh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30794 )
Change subject: mb/intel/kblrvp: Fix unsigned val casting of smaller size
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30794/1/src/mainboard/intel/kblrvp/romstage....
File src/mainboard/intel/kblrvp/romstage.c:
https://review.coreboot.org/#/c/30794/1/src/mainboard/intel/kblrvp/romstage....
PS1, Line 35: if ((s
While this works instead of juggling around types, it seems better to have get_spd_index return succ […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I519ed4b5b403622d6bb01ad0bdd04e01dedff7d8
Gerrit-Change-Number: 30794
Gerrit-PatchSet: 2
Gerrit-Owner: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 06:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment