Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79906?usp=email )
Change subject: [RFC] region: Allow region_end() to return 64-bit numbers
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79906/comment/83478fd0_69726fc7 :
PS1, Line 9: We most likely operate on regions that end exactly at the 4GiB boundary
Well, the idea of the region_create() functions is to avoid overflows. […]
We could also avoid much of the hassle if we'd use 64-bit
integers everywhere and limit offset & size to 63 bits or less.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id261d72c58659f180ca8e5cb6c4bcfc3855ad903
Gerrit-Change-Number: 79906
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 11 Jan 2024 18:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment