Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33623 )
Change subject: superio/fintek: Add f81803a
......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1: Code-Review+1
Looks good, but I can't find a datasheet to double-check.
It's NDA document, I got it directly from AMD. AMD has it because they build some boards (including padmelon) using it. I can only share it with Silverback because we do have an NDA agreement in place.
My real concern was having fan_control.h accepted, because it introduces a new API.
Ack. It would be nice to have superiotool support for this SuperIO, if it is possible (NDA and corporate stuff might be a blocker).
Regarding the HWM API, I'm not experienced enough to judge it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d336e76bccc38452b1b1aefef5d4a4f7ee129a8
Gerrit-Change-Number: 33623
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:25:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
