[coreboot-gerrit] [M] Change in coreboot[master]: acpi: Call acpi_fill_ssdt() only for enabled devices

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47148?usp=email )

Change subject: acpi: Call acpi_fill_ssdt() only for enabled devices
......................................................................

Patch Set 3:

(1 comment)

File src/drivers/intel/dptf/dptf.c:

https://review.coreboot.org/c/coreboot/+/47148/comment/7cce8503_cb732a89 :
PS1, Line 235: if (!dev->enabled)
             : 		return;
             :
> lol Tim, that's actually the workaround I came up with (though setting the name to 0xF), as IMO it's […]

IIUC, this is because the AMD UART device is using a hybrid approach of using raw ASL as well as acpigen. Since this is hopefully an one-off situation, I prefer Tim's recommendation of "setting the raw ASL to have _STA set to the value of a Name which has a default value of 0, and then if it's enabled write one line of acpigen to set that Name to 1".