HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37188 )
Change subject: intel/i945: Call fixup_i945_errata() only for mobile version
......................................................................
Patch Set 2:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/37188/1/src/northbridge/intel/i945/...
File src/northbridge/intel/i945/romstage.c:
https://review.coreboot.org/c/coreboot/+/37188/1/src/northbridge/intel/i945/...
PS1, Line 82: if (CONFIG(NORTHBRIDGE_INTEL_SUBTYPE_I945GM))
Please add the source stating that the errata are only for 945GM and rename the function to fixup_i9 […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2656021b791061b4c22c0b252656a340de76ae5e
Gerrit-Change-Number: 37188
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Mar 2020 21:25:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment