Attention is currently required from: Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 23:
(352 comments)
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/69c76b67_b60292d4 PS23, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2c35b1c3_6faf99da PS23, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d0b76c72_5e0986a5 PS23, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e917ae32_5801bf75 PS23, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/89a3fa8f_76ff08f0 PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/919f2f25_3cd83a21 PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9f6d22b9_97f3d62d PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/db2cfd1a_53439b4e PS23, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/321cc729_9fb05b90 PS23, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ac751c31_95ab8613 PS23, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0bf72640_f98d9292 PS23, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7b513335_4b34729e PS23, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/908fce84_b4c0de4a PS23, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/488e3a84_33ccae0f PS23, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/52d71be3_dde34fd5 PS23, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b200f0ad_d691b046 PS23, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f799a94_ebbbbeb8 PS23, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/48b76298_bad7eb08 PS23, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd0893d8_62df3d14 PS23, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5a55c61b_4874cc8a PS23, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c227fe96_7e3cf28b PS23, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b9c70630_9a4485fa PS23, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7b63c47b_4fbc7d18 PS23, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3788105c_95bc71a2 PS23, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4d2f2c0d_f6709242 PS23, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6a4a4b56_0aa00493 PS23, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b8577e72_fe75e13f PS23, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9c509e43_f97b334b PS23, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d9d6df36_8daa209e PS23, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ed5e9dda_19b7ddf1 PS23, Line 207: trailing whitespace
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/10620786_77f6df8d PS23, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ae3ec3e0_b6ad193c PS23, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/caa9ce78_e782da2e PS23, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/793875b2_35d77d5b PS23, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/59752d46_5d96c301 PS23, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a138ed99_945ed933 PS23, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d3da97ef_7311602f PS23, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8ab39164_f8ac834b PS23, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/64870097_4fd93d4c PS23, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b27e0697_4d78313f PS23, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/41d13c06_07f5780d PS23, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/69e6f402_5fd4cc4f PS23, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f8145ba_55b986d2 PS23, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/616f7ba9_1bed32dc PS23, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b2a78122_b48709ee PS23, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6f646d01_556c76ed PS23, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/45b4cf3b_e24f21af PS23, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/11d842db_d7e331f9 PS23, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b18a3d6c_88e8a36f PS23, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/70acb71c_b89e9bd9 PS23, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4d074772_4fcdc610 PS23, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/da0886b8_a1ed6aa7 PS23, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d31fe226_9b284d30 PS23, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9fb65f7e_a5821816 PS23, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/298cd2a2_cf9fd44d PS23, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/16b0ba1b_882af7a0 PS23, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/01112ae7_c46ee3cc PS23, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/450582f9_430649aa PS23, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e29edb34_1420f21b PS23, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/648430dd_1e48e1b0 PS23, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/86553c69_ee435236 PS23, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/000629e1_8106afa1 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/387e61de_f54736e9 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8d9c8ae8_626717c0 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/529f8c90_be4ee195 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cb866320_f3a46dfd PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a96d5906_34b7a472 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/506c0b9c_a0cf9317 PS23, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1b9c55b7_841daa50 PS23, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1ac709b5_67e35e8b PS23, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/95563120_a97aa701 PS23, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/798862f4_c4a7a331 PS23, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cd808f61_e4be8dd5 PS23, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dc10fd95_fc4e81a8 PS23, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8eae6ed5_59a7684e PS23, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ab9dc22a_152a3301 PS23, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/af954614_4d19e164 PS23, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/33446c31_17a95745 PS23, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cc797e95_04ac27e9 PS23, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/77f5a40a_aa88aa55 PS23, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ade751f0_6a9d10fd PS23, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/706ce303_baf99716 PS23, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/025b47ef_5b17af81 PS23, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/07a8b64d_54752339 PS23, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/70dc6719_392b2a73 PS23, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1a6dcde5_75605005 PS23, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/de1e7c8c_0f2f47e6 PS23, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6221a5ad_fa1ac832 PS23, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f866588a_d8e1bcc7 PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2ad7918c_fb6a309d PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2335a709_2f136089 PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f8c8875a_966d49ae PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd6a1b02_cb99e61c PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bf5d2861_2a450253 PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c27ef375_6e359efc PS23, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/073a62a2_1ca3929d PS23, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f2bf1e7f_54d24d30 PS23, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/46995b84_141b51fb PS23, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f039c50f_25435bdd PS23, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4e167fcf_f7fadd74 PS23, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e95e83a7_717ac7de PS23, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/971d28cd_fe86e6ac PS23, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f6d7b176_7dd5f621 PS23, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/94c32fa3_658d58ff PS23, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fb3dd08c_6230ffb8 PS23, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/82664ea2_15f11833 PS23, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd4c0688_37fc235c PS23, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0e36a54d_eb9ced27 PS23, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9e504a95_8ec18c26 PS23, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9fa6a3c1_af83e51c PS23, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/46a6a61c_61271536 PS23, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/467a0e4b_2edd7e9f PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3ee1fa51_50b0ff96 PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0674bf82_004db7df PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b1b2e51f_c510511d PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/335d2104_da1a7a28 PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/52d3db71_128993b8 PS23, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c8deedb4_d76febbc PS23, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cb1d0999_e16be482 PS23, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/05bd35e6_b560ded9 PS23, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bd4d1e00_cdce6fbb PS23, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7d9f9f6c_c35398c1 PS23, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f46ad4cd_f6dd30c1 PS23, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/72acddf0_118d6dee PS23, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/31572889_c881fad7 PS23, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e0a67310_aad1042b PS23, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b6badeb9_0a5f4d2a PS23, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5dfbfd5a_0870ddee PS23, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/728ab070_0c347a45 PS23, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e675d4c5_984ca55c PS23, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fb9f3bec_3e048bf7 PS23, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d5bc1b85_1781a78f PS23, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4883a93f_c8acb0ce PS23, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2eac9c2a_dbbefdad PS23, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fd092787_1df87662 PS23, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/816dbb33_007180f7 PS23, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8a610aae_c191116e PS23, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/01f4d4c5_56134fb9 PS23, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/992a5fb9_afa28a3a PS23, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/949554c9_1783136c PS23, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/da8ea921_7f61f7ba PS23, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f3217d9f_3e6398f6 PS23, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7f7125b7_3a887afb PS23, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5731d6eb_bf8d0188 PS23, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/385c6df7_77c9f6a5 PS23, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3bf7a39a_70c74169 PS23, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c991cc1c_82f7e19c PS23, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/119f6f28_9586b0e7 PS23, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1c2a4b40_067e43c1 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b91aeeda_4407dca2 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/47dbaaaf_eaf59886 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/eab9cc74_76f44194 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/540d0675_e7be01be PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3bc5e017_d8e24c75 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2c131154_d152cd29 PS23, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e1d5bbc1_480460d5 PS23, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bc1e1516_98dee61f PS23, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/67457a31_ab5f0543 PS23, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1983ec29_a3b49628 PS23, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dca078ef_eac43f30 PS23, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/49f9a730_ea42f87e PS23, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f07ddcb_05a577eb PS23, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/293c86f9_f825b5fb PS23, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f386de8c_fd805f29 PS23, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a3b86876_4f19d523 PS23, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6168e94c_aa30c599 PS23, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/451beb07_ad8dfbf6 PS23, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/935a1b86_16ebb575 PS23, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bebe2df4_8c4b4f18 PS23, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9eafa2d1_bcd1879a PS23, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/331191cc_23773a08 PS23, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7bce2cfd_9cfa4dce PS23, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ec5cfb9b_eeb26380 PS23, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/057cb99d_6454675d PS23, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4be01b89_aedf5e59 PS23, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1651b3ee_91729431 PS23, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/28f18a8b_3e194715 PS23, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/16acbd84_c6f4d521 PS23, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a1b0c5e8_b2aa67da PS23, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5f8239dc_7015f38c PS23, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cbc0f8dd_0cf1019a PS23, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cd597530_22960d7c PS23, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c053de4b_a01800c9 PS23, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/12e28c04_13547e05 PS23, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e691f516_2397cfe6 PS23, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/862937f6_a554b7f6 PS23, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8bfce6cf_e5df9bc7 PS23, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c58103e0_3e0e3067 PS23, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0122240b_23718690 PS23, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/34a18abd_9a6ef613 PS23, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d5db2996_f72b9868 PS23, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/654a33b2_73a89a9c PS23, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c4bedb87_413d3cca PS23, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e5f088c9_61ef8911 PS23, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6c89b18e_9a7ba283 PS23, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4cfb6174_45ffe861 PS23, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c59e2c0f_275ec680 PS23, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a1832cfb_056bb17d PS23, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d0e3045a_4acd0d75 PS23, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f3c70221_8834ab9a PS23, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c40854b2_b04af9cd PS23, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dfafb1cf_3dac297a PS23, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/34f70603_95a52bb2 PS23, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c2a0ddd0_699dd498 PS23, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/df97d841_f5f734a4 PS23, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dbb03e7a_c750ea93 PS23, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7d871afd_21c96ebf PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2a2fd244_005d77f6 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/596e4a13_c50a79ee PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3b4d47d6_45b69d48 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/22b34c2c_7a599434 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0e13e17d_b5dd04d0 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/63289b6f_65055239 PS23, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ba309ef0_0f388f5a PS23, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e86f7ba7_fc5ded3f PS23, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e81b93e2_f7d64b23 PS23, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dff4c23f_ec325dd2 PS23, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5a0dce3a_b6d52269 PS23, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/59592ed3_bdd1643a PS23, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f30fd89f_1918bb34 PS23, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/b1a9cf67_885010b6 PS23, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f59575c5_b1f61fb4 PS23, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/064cae7d_0ad6ab56 PS23, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2e961b38_a0b29489 PS23, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2e615935_d45f3da4 PS23, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a5f73197_8d6898e2 PS23, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0cea26f6_41a15008 PS23, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1b8ec73a_717a8327 PS23, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/891a34dd_b48e27e1 PS23, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fdc4b0df_920fc94c PS23, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cada4c51_336f5ef9 PS23, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/86f4670d_229e145e PS23, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e5d4acea_3aa66fc6 PS23, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ed4b001d_33d3cf03 PS23, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ae128f05_b82db3a4 PS23, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ae21485c_41a7731e PS23, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a29d0823_e2acfe93 PS23, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6b2f4b0c_0c2d968a PS23, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/21921a41_95a03fbd PS23, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/04f78a6c_90f65cc6 PS23, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/62ce982b_1d730690 PS23, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a994a349_52d8926e PS23, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/64d9c6a4_83da207d PS23, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7f0919ab_9a529ca9 PS23, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6f6bbee3_a09619d4 PS23, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c62d05bf_f20be2e6 PS23, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a705f875_02f74b59 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/596b255b_a12ce0c4 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9ebcb3b2_99d7637b PS23, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3afa3ede_5daf30f5 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/737a982f_a4b14aea PS23, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e63bf3e3_733eff94 PS23, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dfb43f26_d9552c1e PS23, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/71b5c04c_9e462268 PS23, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/11c750ad_7d402eba PS23, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a19eff42_e0d9e143 PS23, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2fd322c6_2a5636ba PS23, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3e180ec5_c018b72a PS23, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2375e8b6_0caeeef5 PS23, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5c617d2b_ea62bdd8 PS23, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f26de770_9b8c2724 PS23, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/12293fc4_9823be4f PS23, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/10c6d532_576ba5a8 PS23, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/846f3604_1227ee2a PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/33d6c68b_689f403b PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/452b5be6_6431a7ec PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e7650ed8_23832802 PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c2522057_c5b6e8cb PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7c19dd93_da53d06c PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8b2af4d7_78a4f3fc PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3d840013_5308330c PS23, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8ea37143_0db0833b PS23, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fcdf7730_d4948cb9 PS23, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f2bac408_155aa6b3 PS23, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/270090ee_b7e34449 PS23, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/65197d8c_eefb91fc PS23, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/62d96d31_6e641cf4 PS23, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/23ca7e40_12bb8e0a PS23, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1a6e46e6_40701901 PS23, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8d21249c_db0442e6 PS23, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ddf08366_f33812d5 PS23, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/67bcf07b_2228fb5f PS23, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/887e91aa_be7ecfd8 PS23, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4eab75ab_2d65aaac PS23, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/42f37e4f_08c7de1d PS23, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/bafa0f2f_400897cc PS23, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/683ae327_f6354c37 PS23, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e3c9c8cc_66a957d2 PS23, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/107cd6f0_4c27bc1a PS23, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/68125909_099e4e43 PS23, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f5078650_c22b9176 PS23, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/54e196a6_a226bcbd PS23, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/55be1a27_df846e04 PS23, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/464601a2_358651e5 PS23, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ac9f37fe_9bc420de PS23, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/12de4e9f_7edfdfd6 PS23, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4d355eb3_822020fc PS23, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5c8e0898_73c8aaf1 PS23, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/dd412be4_5e8133c2 PS23, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/20750c4f_81314a95 PS23, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2d818c5f_187b8316 PS23, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8f630f69_65a5f2f6 PS23, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/1cfc3291_67a532ad PS23, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/16ce603a_53de7d87 PS23, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/34efd289_d07f7394 PS23, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e5560727_28a464ed PS23, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ed0419ae_e2073aa1 PS23, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/275894f6_b8b9439e PS23, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/09a000a3_133a3eb0 PS23, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/0945cd39_e68f528b PS23, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f152a5a0_9a149c82 PS23, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/7b303a88_23c363f0 PS23, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c75618e2_96e0ceb1 PS23, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/841f821b_3eaa9e42 PS23, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/98005c9c_71ab77c2 PS23, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5589cced_7d355bcd PS23, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d333c816_1a1a7497 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/30ef5451_e57b1609 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/96f9b19a_9452c7c5 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/82482ed9_9be86ce9 PS23, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f4e60f7e_e5489aa7 PS23, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/5fee72ce_9f17173f PS23, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/e9670b37_abb8c656 PS23, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/c905d681_f7e1f9ab PS23, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a46b9d94_d3a9a093 PS23, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/754e8e41_9d07c683 PS23, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/4772a886_e85a678e PS23, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/71244850_25060385 PS23, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/cc499a35_ba794641 PS23, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/9f4f516a_caf2a0a6 PS23, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/8da433cf_aaeab9f3 PS23, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/ce726a8e_f69db7f8 PS23, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/6279d112_636917b6 PS23, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/363e745d_674ded79 PS23, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/76e82627_12338568 PS23, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/d22c9f4c_67a7000d PS23, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/f5796f33_e3bd7664 PS23, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/427fd8d4_70dbe021 PS23, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2ee882d9_7dedbf12 PS23, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/993a7912_90d6c141 PS23, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3c1ec47c_1b26e152 PS23, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/00664a86_ad8fb019 PS23, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3c504a1a_e958f152 PS23, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/3790a7e1_8096328e PS23, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/69e50b2f_9fbec05e PS23, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a50fb95b_8f16c4a0 PS23, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/fdc1110e_d8ead411 PS23, Line 188: } please, no spaces at the start of a line
File util/coreboot-configurator/src/application/toggleswitch.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/77ab51d9_43c6fc21 PS23, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/a37c0fe5_8371abdc PS23, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/01cafe63_e4f40cc6 PS23, Line 25: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/2c1a4375_c51f53f2 PS23, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132355): https://review.coreboot.org/c/coreboot/+/58854/comment/458efdf3_9270d931 PS23, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV)