Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44397 )
Change subject: mb/google/dedede: Replace static Camera ACPI by driver for WDoo ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... PS9, Line 184: ACPI_DT_NAMESPACE_HID
This is already the default for VCM so doesn't need to be specified.
ACK
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... PS9, Line 185: 0
the drivers/spi/acpi driver (for cr50) will just use the UID it was given (or defaulted to 0), which […]
Please correct me if I am wrong here, if PRP0001 is returned by _HID, the ACPI subsystem will look for the "compatible" property in the device object's _DSD and will use the value of that property to identify the corresponding device in analogy with the original DT device identification algorithm. So will it matter if we have same HID and UID for two devices. Also the scope of these two devices VCM and CR50 will be different.
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... PS9, Line 196: ACPI_DT_NAMESPACE_HID
I thought NVM devices used INT3499 (which is the mipi camera driver's default). […]
I think the ACPI subsystem will look for the "compatible" property in _DSD and link the driver according to the string, which in this case is "atmel,24c1024"
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... PS9, Line 229: "GPP_D13" #power_enable_2p8 : register "gpio_panel.gpio[1].gpio_num" = "GPP_D14"
I didn't follow the ref-counting change but I'm assuming it's doing some ref-counting on D13 and D14 […]
Yes this is correct