Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48934 )
Change subject: [RFC] device/pnp: do not warn for generic unassigned ressources
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I still don't see what this warning really is for... Sombody ports a board and adds a SIO driver. This person can check what registers "need" to be configured. So, would they want to warn themselves (which is not very sensible ofc) or others? What if a SIO gets used by a different board later but the register does *not* need to be set there because the board doesn't use that function? Then they get a warning, which is meaningless for that board.
I can't say that I know all SIOs. It seems possible that there are LDNs that if
enabled need a specific register set.
If an LDN is disabled, the resource assignment shouldn't run, no warning would
be printed.
Nico, I read your comment again and now wonder, if I got it right or not. Is your idea to first remove all PNP_MSC that are not needed and then, if none is left, drop the warning, which is dead code then?
Not my idea, but a valid conclusion if all PNP_MSC* declarations look spurious
(wrt. to the warning).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic23852d525a3f9c95118b113d419f815cac002d3
Gerrit-Change-Number: 48934
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 30 Apr 2021 20:31:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment