Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38737 )
Change subject: soc/tigerlake: Update FSP UPDs to turn on USB4/TBT
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38737/4/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/38737/4/src/soc/intel/tigerlake/rom...
PS4, Line 125: m_cfg->TcssItbtPcie0En = config->TcssItbtPcie0En;
: m_cfg->TcssItbtPcie1En = config->TcssItbtPcie1En;
: m_cfg->TcssItbtPcie2En = config->TcssItbtPcie2En;
: m_cfg->TcssItbtPcie3En = config->TcssItbtPcie3En;
:
Can we also use same condition check for device enabled?
dev = pcidev_on_root(SA_DEV_SLOT_TBT, i);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f020e20fa8e9fd1ac69d883f4dc1fcbb330a3bf
Gerrit-Change-Number: 38737
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Tue, 17 Mar 2020 19:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment