[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/pineview: Correct lsbpos(0) and msbpos(0)

[Jacob Garber (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins), Damien Zammit,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32054

to look at the new patch set (#3).

Change subject: nb/intel/pineview: Correct lsbpos(0) and msbpos(0)
......................................................................

nb/intel/pineview: Correct lsbpos(0) and msbpos(0)

lsbpos and msbpos have incorrect behaviour when given 0.
lsbpos(0) returns 8, and msbpos(0) hangs. The latter is because
the check i >= 0 is always true for an unsigned integer, causing
it to loop indefinitely. This was flagged as CID 1347356, 1347386.
0 doesn't have a lsb or msb position, so we change both to return
-1 on this case to indicate an error.

Signed-off-by: Jacob Garber 
Change-Id: Ic5be50846cc545dcd48593e5ed3fd6068a6104cb
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 12 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/32054/3