Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37539 )
Change subject: drivers/i2c/rt5663/: fix missing header include
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/chip...
File src/drivers/i2c/rt5663/chip.h:
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/chip...
PS1, Line 18: #include <stdint.h>
But it's used independently from ACPI. e.g. if one would remove the […]
Done
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/rt56...
File src/drivers/i2c/rt5663/rt5663.c:
https://review.coreboot.org/c/coreboot/+/37539/1/src/drivers/i2c/rt5663/rt56...
PS1, Line 15: #include <arch/acpi_device.h>
Same here, if one would remove the fields in `chip.h`...
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I987f0ec6f769e550f3421629e0ef0c579a3d12f9
Gerrit-Change-Number: 37539
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Dec 2019 13:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
