Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35484 )
Change subject: util/smc: Add and use new tool smcbiosinfo
......................................................................
Patch Set 13:
(1 comment)
There might be a name clash with
https://review.coreboot.org/c/coreboot/+/35484/13//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35484/13//COMMIT_MSG@7
PS13, Line 7: smc
This abbreviation of "Supermicro" confused me. "SMC" also refers to the "System Management Controller" on Apple hardware. Maybe rename the `util/smc/` directory to `util/supermicro/` instead? The tool names are fine as-is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id608c2ce78614b45a2fd0b26d97d666f02223998
Gerrit-Change-Number: 35484
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 12 Dec 2019 19:14:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment