Attention is currently required from: Arthur Heymans, Iru Cai, Maxim, Nicholas Chin, Tristan Corrick.
Angel Pons has posted comments on this change by Iru Cai. ( https://review.coreboot.org/c/coreboot/+/30890?usp=email )
Change subject: autoport: Add support for Haswell-LynxPoint platform
......................................................................
Patch Set 35:
(1 comment)
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/188b39fd_32476f36?usp... :
PS35, Line 189: "sata_port_map": fmt.Sprintf("0x%x", PCIMap[PCIAddr{Bus: 0, Dev: 0x1f, Func: 2}].ConfigDump[0x92]&0x3f),
This crashes when the SATA device is disabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30890?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f6e8c97b5122101de2f36bba8ba9f8ddd5b813a
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 35
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Jamal Wright
Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Maxim
max.senia.poliak@gmail.com
Gerrit-Reviewer: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@slrie.de
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Maxim
max.senia.poliak@gmail.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Sun, 02 Jun 2024 11:42:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No