[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8183: Add missing register settings for channels

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42193 )

Change subject: soc/mediatek/mt8183: Add missing register settings for channels
......................................................................

Patch Set 7:

(4 comments)

Almost done!

https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@9 
PS2, Line 9: Fix some programming errors.
> Also mention the typo fix. […]

Left another comment.

https://review.coreboot.org/c/coreboot/+/42193/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42193/7//COMMIT_MSG@9 
PS7, Line 9: add
so add

https://review.coreboot.org/c/coreboot/+/42193/7//COMMIT_MSG@9 
PS7, Line 9: need
need to

https://review.coreboot.org/c/coreboot/+/42193/7//COMMIT_MSG@10 
PS7, Line 10: missing settings.
Please add

Also fix a typo (0x1 < 0) to (0x1 << 0).