Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85614?usp=email )
Change subject: soc/intel/pantherlake: Update Crashlog config ......................................................................
soc/intel/pantherlake: Update Crashlog config
This will configure CpuCrashLogEnable regardless of Tracehub configuration as Crashlog feature does not have a dependency with Tracehub.
TEST=Build fatcat and check Crashlog is enabled without enabling Tracehub.
Change-Id: I6f37e9f4a1f55ffc576af955c92d4073068eb97a Signed-off-by: Jamie Ryu jamie.m.ryu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85614 Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com --- M src/soc/intel/pantherlake/romstage/fsp_params.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Subrata Banik: Looks good to me, approved Jérémy Compostella: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/pantherlake/romstage/fsp_params.c b/src/soc/intel/pantherlake/romstage/fsp_params.c index 7d965fd..5b96891 100644 --- a/src/soc/intel/pantherlake/romstage/fsp_params.c +++ b/src/soc/intel/pantherlake/romstage/fsp_params.c @@ -249,11 +249,12 @@ static void fill_fspm_trace_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_pantherlake_config *config) { + m_cfg->CpuCrashLogEnable = CONFIG(SOC_INTEL_CRASHLOG); + if (!CONFIG(SOC_INTEL_COMMON_BLOCK_TRACEHUB)) return;
m_cfg->PlatformDebugOption = CONFIG_SOC_INTEL_COMMON_DEBUG_CONSENT; - m_cfg->CpuCrashLogEnable = CONFIG(SOC_INTEL_CRASHLOG);
switch (CONFIG_SOC_INTEL_COMMON_DEBUG_CONSENT) { case HW_DEBUG_TRACEHUB_ACTIVE: